Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: make tests optional during build #71

Merged
merged 1 commit into from
Feb 25, 2020
Merged

Conversation

gocarlos
Copy link
Member

this is important for some package managers like conan and yocto

@coveralls
Copy link

Coverage Status

Coverage remained the same at 95.218% when pulling 114b1bf on gocarlos:master into fdabbdc on cose-wg:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 95.218% when pulling 114b1bf on gocarlos:master into fdabbdc on cose-wg:master.

@jimsch
Copy link
Contributor

jimsch commented Feb 25, 2020

Does this need to be carried down to the building of the cbor library as well?

@gocarlos
Copy link
Member Author

gocarlos commented Feb 25, 2020

well, basically the best case is that the cmake script has an option to find the libraries in the filesystem or to download them as implemented now...

I did not make any changes so far there because the library (cn-cbor) seems unmaintained...

@jimsch
Copy link
Contributor

jimsch commented Feb 25, 2020

Yes the base library is not maintained. However I am still trying to do some maintenance in the branch that gets pulled by the cmake script. I just haven't gotten in there recently.

@jimsch jimsch merged commit bd79cef into cose-wg:master Feb 25, 2020
@jimsch
Copy link
Contributor

jimsch commented Feb 25, 2020

Yes the base library is not maintained. However I am still trying to do some maintenance in the branch that gets pulled by the cmake script. I just haven't gotten in there recently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants