Add ~/, $VAR, and %VAR% support #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for ~/, $VAR, and %VAR% style shorthand in configuration file path and configuration file RepositoryRoot paths.
We now support expanding vars and have test coverage for the new features.
We have to create special data for Unix vs Windows platforms for the PathHelper tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for config file paths and contents that use ~/ and environmental variables. Note that
we only support one level of nesting for variables. We could support nested variables but that's more
work that I want to commit to this at the moment.
This also cleans up some exception handling so the user experience is slightly better in cases of bad
configuration entries.