Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

on 0.1.3 date sort outter groups are not sorted #7

Closed
corytodd opened this issue Aug 24, 2021 · 0 comments · Fixed by #8
Closed

on 0.1.3 date sort outter groups are not sorted #7

corytodd opened this issue Aug 24, 2021 · 0 comments · Fixed by #8
Assignees
@corytodd
Labels
bug Something isn't working

Comments

@corytodd
Copy link
Owner

When issuing a query with group-by date, the outer date grouping is not sorted.

walrusc query --group-by date

The top-level groups are arbitrary. The inner commit timestamps are sorted though.
@corytodd corytodd self-assigned this Aug 24, 2021
@corytodd corytodd added the bug Something isn't working label Aug 24, 2021
corytodd added a commit that referenced this issue Aug 24, 2021
@corytodd
fix group by date issue #7
aefd9aa 
Sort commits before grouping by date. Only incur the sort cost
for sorting by date.
@corytodd corytodd mentioned this issue Aug 24, 2021
Merged
corytodd added a commit that referenced this issue Aug 24, 2021
@corytodd
Merge pull request #8 from corytodd/fix_date_sort
a585822 
fix group by date issue #7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@corytodd corytodd

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix group by date issue #7 corytodd/Walrus
1 participant
@corytodd