fix flaky test job config, fix Docker file entry error (knative#584)

coryrc · Mar 19, 2019 · 1697c4c · 1697c4c
1 parent 8e56bf9
commit 1697c4c
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 7 deletions.
diff --git a/ci/prow/config.yaml b/ci/prow/config.yaml
@@ -2744,9 +2744,9 @@ periodics:
       command:
       - "/flaky-test-reporter"
       args:
-      - "--service-account /etc/test-account/service-account.json"
-      - "--github-account /etc/flaky-test-reporter-github-token/token"
-      - "--slack-account /etc/flaky-test-reporter-slack-token/token"
+      - "--service-account=/etc/test-account/service-account.json"
+      - "--github-account=/etc/flaky-test-reporter-github-token/token"
+      - "--slack-account=/etc/flaky-test-reporter-slack-token/token"
       volumeMounts:
       - name: test-account
         mountPath: /etc/test-account

diff --git a/ci/prow/make_config.go b/ci/prow/make_config.go
@@ -779,9 +779,9 @@ func generateFlakytoolPeriodicJob() {
 	data.CronString = flakesreporterPeriodicJobCron
 	data.Base.Command = "/flaky-test-reporter"
 	data.Base.Args = []string{
-		"--service-account " + data.Base.ServiceAccount,
-		"--github-account /etc/flaky-test-reporter-github-token/token",
-		"--slack-account /etc/flaky-test-reporter-slack-token/token"}
+		"--service-account=" + data.Base.ServiceAccount,
+		"--github-account=/etc/flaky-test-reporter-github-token/token",
+		"--slack-account=/etc/flaky-test-reporter-slack-token/token"}
 	addExtraEnvVarsToJob(&data.Base)
 	configureServiceAccountForJob(&data.Base)
 	addVolumeToJob(&data.Base, "/etc/flaky-test-reporter-github-token", "flaky-test-reporter-github-token", true)

diff --git a/images/flaky-test-reporter/Dockerfile b/images/flaky-test-reporter/Dockerfile
@@ -24,7 +24,7 @@ ADD . $TEMP_REPO_DIR
 
 # Build flaky test reporter tool in the container
 RUN make -C $TEMP_REPO_DIR/tools/$TOOL_NAME/
-RUN cp $TEMP_REPO_DIR/tools/$TOOL_NAME/$TOOL_NAME .
+RUN cp $TEMP_REPO_DIR/tools/$TOOL_NAME/$TOOL_NAME /$TOOL_NAME
 
 # Remove test-infra from the container
 RUN rm -fr $TEMP_REPO_DIR