Remove refs to analyzers implied by Endjin.RecommendedPractices #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Several projects had ended up with explicit references to Roslynator.Analyzers and StyleCop.Analyzers. These are unnecessary because Endjin.RecommendedPractices includes them automatically. (This usually happens when those analyzer packages get updated - the NuGet explorer doesn't understand that they've come in via Endjin.RecommendPractices, because transient build-time dependencies aren't really a thing in NuGet so we had to employ a hack to make that work in Endjin.RecommendedPractices. NuGet spuriously offers to update the refs for you, at which point you end up with explicit references.)
HowardvanRooijen
approved these changes
May 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several projects had ended up with explicit references to Roslynator.Analyzers and StyleCop.Analyzers. These are unnecessary because Endjin.RecommendedPractices includes them automatically.
(This usually happens when those analyzer packages get updated - the NuGet explorer doesn't understand that they've come in via Endjin.RecommendPractices, because transient build-time dependencies aren't really a thing in NuGet so we had to employ a hack to make that work in Endjin.RecommendedPractices. NuGet spuriously offers to update the refs for you, at which point you end up with explicit references.)