Address naming collisions in schema islands #302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d spaces - If it does, we prepend the name derived from the path (not the fragment) if a path exists; this fixes the issue of identically named entities - If we still have collisions, we append a monotonically incrementing number; this is where you have a schema with multiple data islands with colliding names. - Added a stable ordering for setting dotnet type name and namespace
mwadams
deleted the
feature/301-type-name-collisions-when-referencing-schema-islands
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you have schema islands (such as those in OpenApi documents), there is no guarantee that referenced schema will be in a unique namespace based on the existing heuristic.
In order to address this we have: