Simplifying generated API surface area #246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed bug: UTF8 decoding was not correctly passing idx in one path - it was using 0.
…id overhwelming the static type scope.
Explicit cast => string GetString() =? string? TryGetString() => string [NotNullWhen(true)]
…nerators to spit out clean code.
The JsonEverything benchmark was artificially quick because it was using an old version of the schema that did not reflect the additional constraints Corvus.JsonSchema was required to apply by the new schema.
The JsonEverything benchmark was artificially quick because it was using an old version of the schema that did not reflect the additional constraints Corvus.JsonSchema was required to apply by the new schema.
- Partial URI resolution may decompose compound query strings.
…-dotnet/Corvus.JsonSchema into feature/simplify-building
- CodeGenerator bugs are fixed, so we can use the generators in these cases.
-- Pending update to Corvus.UriTemplates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.