Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation comments duplicated #440

Closed
mwadams opened this issue Sep 30, 2024 · 1 comment
Closed

Documentation comments duplicated #440

mwadams opened this issue Sep 30, 2024 · 1 comment
Assignees
@mwadams
Labels
bug Something isn't working
Milestone
V4.0

Comments

@mwadams
Copy link
Contributor

mwadams commented Sep 30, 2024

Given the following schema:
schema.json

Document comments are emitted twice.

image

Version: 4.0.0-preview.17
@mwadams mwadams added the bug Something isn't working label Sep 30, 2024
@mwadams mwadams added this to the V4.0 milestone Sep 30, 2024
@mwadams mwadams self-assigned this Sep 30, 2024
mwadams added a commit that referenced this issue Oct 1, 2024
@mwadams
Fixed bug #440
7cb73e4 
De-duplicated documentation when the property type is not reducible.
@mwadams mwadams mentioned this issue Oct 1, 2024
Merged
mwadams added a commit that referenced this issue Oct 1, 2024
@mwadams
Feature/440 documentation comments duplicated (#441)
e256f9f 
* Fixed bug: line spaces no longer being applied.

* Failing test added.

* Fixed bug #440

De-duplicated documentation when the property type is not reducible.

* Include all unreduced type short documentation.
@mwadams
Copy link
Contributor Author

mwadams commented Oct 1, 2024

Resolved in v4.0.0-preview.19

@mwadams mwadams closed this as completed Oct 1, 2024
mwadams added a commit that referenced this issue Nov 12, 2024
@mwadams
Feature/440 documentation comments duplicated (#441)
9e706a2 
* Fixed bug: line spaces no longer being applied.

* Failing test added.

* Fixed bug #440

De-duplicated documentation when the property type is not reducible.

* Include all unreduced type short documentation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mwadams mwadams

Labels
bug Something isn't working
Projects
None yet
Milestone
V4.0
Development

No branches or pull requests
1 participant
@mwadams