Use Detekt with type resolution #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cortinico
approved these changes
Aug 28, 2024
| @@ -32,6 +32,7 @@ gradlePlugin { | |||
| version = property("VERSION").toString() | |||
| description = property("DESCRIPTION").toString() | |||
| displayName = property("DISPLAY_NAME").toString() | |||
| // Note: tags cannot include "plugin" or "gradle" when publishing | |||
There was a problem hiding this comment.
Let's remove them from line 36 then?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Description
Replaces default detekt task with detektMain (type resolution) when running
check📄 Motivation and Context
Enables the Detekt rules that require type resolution to run by default
🧪 How Has This Been Tested?
Tested by running
preMergeand introducing errors that require TR to identify📦 Types of changes
✅ Checklist