Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update thanos version to 62038110b1bc #6294

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

harry671003
Copy link
Contributor

@harry671003 harry671003 commented Oct 30, 2024

What this PR does:
Updating thanos dependency to thanos-io/thanos@6203811.

The only major change that will impact cortex is:

Which issue(s) this PR fixes:
Fixes #

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@dosubot dosubot bot added dependencies Pull requests that update a dependency file go Pull requests that update Go code labels Oct 30, 2024
@yeya24
Copy link
Contributor

yeya24 commented Oct 30, 2024

For the lint issue, let's upgrade the dependency to v0.3.4, similar to prometheus/prometheus#15166?

@yeya24
Copy link
Contributor

yeya24 commented Oct 30, 2024

@SungJin1212 https://github.com/cortexproject/cortex/actions/runs/11585758704/job/32255315640?pr=6294
This may related to the new disable chunk trimming change

Signed-off-by: 🌲 Harry 🌊 John 🏔 <[email protected]>
@harry671003
Copy link
Contributor Author

Looks like the test is flaky.

@SungJin1212
Copy link
Contributor

@harry671003
Yes, it seems that.
I get the intermittent error even if two Cortexs use the same image, quay.io/cortexproject/cortex:v1.18.0. It seems to be a bug in the test code.

Copy link
Contributor

@yeya24 yeya24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Oct 30, 2024
@yeya24 yeya24 merged commit 00c7b68 into cortexproject:master Oct 30, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file go Pull requests that update Go code lgtm This PR has been approved by a maintainer size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants