Fix S3 BucketWithRetries upload empty content issue #5217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ory allocations (cortexproject#5213) Signed-off-by: Xiaochao Dong (@damnever) <[email protected]> Signed-off-by: Alex Le <[email protected]>
Signed-off-by: Alex Le <[email protected]>
alexqyle
force-pushed
the
s3-upload-retry-issue
branch
from
0c7c441 to
5a5e662
Compare
Signed-off-by: Alex Le <[email protected]>
…mize memory allocations (cortexproject#5213)" This reverts commit 4821ba3. Signed-off-by: Alex Le <[email protected]>
alanprot
approved these changes
Mar 20, 2023
|
Good catch! Thanks for fixing it |
danielblando
approved these changes
Mar 20, 2023
alanprot
reviewed
Mar 20, 2023
alvinlin123
reviewed
Mar 20, 2023
alvinlin123
reviewed
Mar 20, 2023
Signed-off-by: Alex Le <[email protected]>
Signed-off-by: Alex Le <[email protected]>
Signed-off-by: Alex Le <[email protected]>
alanprot
reviewed
Mar 20, 2023
yeya24
reviewed
Mar 20, 2023
Signed-off-by: Alex Le <[email protected]>
Signed-off-by: Alex Le <[email protected]>
alvinlin123
approved these changes
Mar 20, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
BucketWithRetriesfor S3 reused the same Reader inside retry logic which caused empty content got uploaded during retry. This PR should fix this problem by only retrying upload operation if the input Reader is seekable.Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]