Upgraded Thanos #3661
Merged
Upgraded Thanos #3661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR introduces a lock to fix it: |
|
Cortex changes LGTM. Amazing that you could spot a new race bug in that huge Thanos diff! |
pstibrany
reviewed
Jan 8, 2021
Signed-off-by: Marco Pracucci <[email protected]>
pracucci
force-pushed
the
upgrade-thanos
branch
from
9227f45 to
7e94431
Compare
Signed-off-by: Marco Pracucci <[email protected]> Co-authored-by: Peter Štibraný <[email protected]>
Signed-off-by: Marco Pracucci <[email protected]>
|
@pstibrany Thanks for your review. The Thanos fix thanos-io/thanos#3705 has been merged and I've upgraded Thanos again, so should be ready for another review. |
pstibrany
approved these changes
Jan 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
In this PR I'm upgrading Thanos to bring in a couple of changes we did (see CHANGELOG). I also took the opportunity to refactor the chunks storage swift client to use the blocks storage config (this brings in a breaking change to
container-namedefault value, but swift is still marked experimental).Do not merge: I reviewed all Thanos changes and I've found a race condition introduced by thanos-io/thanos#3557. I need to fix it merge merging this PR.(Fixed)Most Thanos changes are small and safe things. This optimisation PR thanos-io/thanos#3531 is worth noting: diff is not easy to review but I did my best to compare before/after and changes LGTM.
Which issue(s) this PR fixes:
N/A
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]