Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Loads schemacfg with correct flagset #2917

Merged
merged 1 commit into from
Jul 23, 2020
Merged

Loads schemacfg with correct flagset #2917

merged 1 commit into from
Jul 23, 2020

Conversation

owen-d
Copy link
Contributor

@owen-d owen-d commented Jul 22, 2020

Fixes a small issue loading the SchemaConfig which used the global flagset instead of the passed flagset.

@owen-d owen-d mentioned this pull request Jul 22, 2020
Merged
pracucci
pracucci approved these changes Jul 23, 2020
View reviewed changes
Copy link
Contributor

@pracucci pracucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I found several of these issues when I wrote the config file reference generator tool, but since the schema config is out of that these issues haven't been found there. Thanks again for the fix! ❤️

jtlisi
jtlisi approved these changes Jul 23, 2020
View reviewed changes
Copy link
Contributor

@jtlisi jtlisi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pracucci pracucci merged commit cedb0b4 into cortexproject:master Jul 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtlisi jtlisi jtlisi approved these changes

@pracucci pracucci pracucci approved these changes

Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@owen-d @pracucci @jtlisi