-
Notifications
You must be signed in to change notification settings - Fork 808
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added -store.max-chunks-per-query limit support to blocks storage #2852
Added -store.max-chunks-per-query limit support to blocks storage #2852
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, good job.
(I'm becoming more nervous about mixing direct and atomic access to the same variable, although in this specific case, there is clear happens-before relationship between the two, so I think it is correct. [Talking about numChunks
in fetchSeriesFromStores
method])
…y limit support to blocks storage Signed-off-by: Marco Pracucci <[email protected]>
Signed-off-by: Marco Pracucci <[email protected]>
Thanks!
It's safe because of the |
Signed-off-by: Marco Pracucci <[email protected]>
b45bd5d
to
4d68aaa
Compare
To expand on this comment, I think my reasoning is wrong. Program happens-before order, and atomic accesses are independent, so correct version of the code should use atomic load at the end of But no need to change it in this PR... we have similar code elsewhere. |
This is what I thought as well. Unfortunately, there is no such guarantee. |
Signed-off-by: Marco Pracucci <[email protected]>
What this PR does:
In this PR:
-store.max-chunks-per-query
limit support to blocks storagemax-sample-count
support because it's flawed in Thanos (it's per block and not per query as documented). I will work on this in a subsequent PR (I need to fix it in Thanos first) and the limit in store-gateway will be based on-store.max-chunks-per-query
too.Out of the scope of this PR:
Which issue(s) this PR fixes:
Fixes #2844
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]