Allow the query-frontend code to proxy queries to 'vanilla' Prometheus. #1441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomwilkie
force-pushed
the
frontend-for-prometheus
branch
from
c304bc5 to
63baf71
Compare
Signed-off-by: Tom Wilkie <[email protected]>
tomwilkie
force-pushed
the
frontend-for-prometheus
branch
from
63baf71 to
3085349
Compare
- Allow specification of target in config file. - Allow sepcification of HTTP prefix (/api/prom), so we can drop it to look like a 'normal' prometheus. - Fix forwarding request to normal Prometheus. Signed-off-by: Tom Wilkie <[email protected]>
Signed-off-by: Tom Wilkie <[email protected]>
tomwilkie
force-pushed
the
frontend-for-prometheus
branch
from
3085349 to
981f128
Compare
tomwilkie
commented
Aug 19, 2019
| @@ -99,6 +103,7 @@ func New(cfg Config, log log.Logger, limits *validation.Overrides) (*Frontend, e | |||
| log: log, | |||
| queues: map[string]chan *request{}, | |||
| } | |||
| f.cond = sync.NewCond(&f.mtx) | |||
There was a problem hiding this comment.
This is just a move, used to be at bottom of the function. Prefer it here, but can do in different PR if necessary.
gouthamve
approved these changes
Aug 19, 2019
Signed-off-by: Tom Wilkie <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to get all the benefits of the query-frontend (caching, splitting, aligning, retires etc) with OSS Prometheus.
eg
Signed-off-by: Tom Wilkie [email protected]