-
Notifications
You must be signed in to change notification settings - Fork 808
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use prometheus/tsdb in ingester. #1427
Conversation
Signed-off-by: Tom Wilkie <[email protected]>
Signed-off-by: Tom Wilkie <[email protected]>
I can pick TSDB changes to be made 1 by 1, starting with series limit. |
Limit series in TSDB: prometheus-junkyard/tsdb#617 |
Edit: I think we could then extend that to just make it easy to get the # of active series in TSDB (looks like right now we just have the gauge metric) rather than having to add a limit to TSDB itself, and then Cortex can ask TSDB for that value when checking if there's room for more series for a given user? |
@cstyan Yes, after I opened the PR in TSDB to have limits on number of series, it looks unnecessary to have it in TSDB. We should be able to handle that in cortex (with or without TSDB per user ID). |
@@ -53,6 +53,9 @@ type Series interface { | |||
|
|||
// Iterator returns a new iterator of the data of the series. | |||
Iterator() SeriesIterator | |||
|
|||
// Chunks returns a copy of the compressed chunks that make up this series. | |||
Chunks() []chunks.Meta |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where is this coming from? I cannot see this on tip of TSDB 🤔 nor 0.8.0 which go mod
vendors here.
Is this manually modifed TSDB code in vendor? Cannot see any replace
directive on go.mod
as well so you don't use fork as well...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just added it here; opening a TSDB PR now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Closing in favour of #1695. |
This PR is the first attempt at using prometheus/tsdb in the ingester.
There is lots missing/TODO: