Remove deprecated chunks dashboards

Signed-off-by: Friedrich Gonzalez <[email protected]>
cortexproject · May 27, 2024 · 1a61a80 · 1a61a80
1 parent 6804d0a
commit 1a61a80
Show file tree

Hide file tree

Showing 10 changed files with 5 additions and 477 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,7 @@
 
 ## master / unreleased
 * [CHANGE] Enable shuffle sharding in compactors
+* [CHANGE] Remove chunks support for dashboards
 * [ENHANCEMENT] Configure `-ingester.client.grpc-compression` to be `snappy-block`
 * [ENHANCEMENT] Support Grafana 11 in Cortex Service Scaling Dashboard
 

diff --git a/cortex-mixin/alerts/alerts.libsonnet b/cortex-mixin/alerts/alerts.libsonnet
@@ -71,27 +71,6 @@
             |||,
           },
         },
-        {
-          // We're syncing every 10mins, and this means with a 5min rate, we will have a NaN when syncs fail
-          // and we will never trigger the alert.
-          // We also have a 3h grace-period for creation of tables which means the we can fail for 3h before it's an outage.
-          alert: 'CortexTableSyncFailure',
-          expr: |||
-            100 * rate(cortex_table_manager_sync_duration_seconds_count{status_code!~"2.."}[15m])
-              /
-            rate(cortex_table_manager_sync_duration_seconds_count[15m])
-              > 10
-          |||,
-          'for': '30m',
-          labels: {
-            severity: 'critical',
-          },
-          annotations: {
-            message: |||
-              {{ $labels.job }} is experiencing {{ printf "%.2f" $value }}% errors syncing tables.
-            |||,
-          },
-        },
         {
           alert: 'CortexQueriesIncorrect',
           expr: |||

diff --git a/cortex-mixin/config.libsonnet b/cortex-mixin/config.libsonnet
@@ -3,18 +3,7 @@
   grafanaDashboardShards: 4,
 
   _config+:: {
-    // Switch for overall storage engine.
-    // May contain 'chunks', 'blocks' or both.
-    // Enables chunks- or blocks- specific panels and dashboards.
-    storage_engine: ['blocks'],
-
-    // For chunks backend, switch for chunk index type.
-    // May contain 'bigtable', 'dynamodb' or 'cassandra'.
-    chunk_index_backend: ['bigtable', 'dynamodb', 'cassandra'],
-
-    // For chunks backend, switch for chunk store type.
-    // May contain 'bigtable', 'dynamodb', 'cassandra', 's3' or 'gcs'.
-    chunk_store_backend: ['bigtable', 'dynamodb', 'cassandra', 's3', 'gcs'],
+    storage_engine: ['blocks'],  // TODO: Remove this option, it's not needed
 
     // Tags for dashboards.
     tags: ['cortex'],
@@ -32,7 +21,6 @@
       ruler: '(ruler|cortex$)',
       query_frontend: '(query-frontend.*|cortex$)',  // Match also custom query-frontend deployments.
       query_scheduler: 'query-scheduler.*',  // Not part of single-binary. Match also custom query-scheduler deployments.
-      table_manager: '(table-manager|cortex$)',
       ring_members: ['compactor', 'distributor', 'ingester.*', 'querier.*', 'ruler', 'store-gateway', 'cortex'],
       store_gateway: '(store-gateway|cortex$)',
       gateway: '(gateway|cortex-gw|cortex-gw-internal)',

diff --git a/cortex-mixin/dashboards.libsonnet b/cortex-mixin/dashboards.libsonnet
@@ -9,22 +9,9 @@
     (import 'dashboards/writes.libsonnet') +
     (import 'dashboards/slow-queries.libsonnet') +
     (import 'dashboards/rollout-progress.libsonnet') +
-
-    (if std.member($._config.storage_engine, 'blocks')
-     then
-       (import 'dashboards/compactor.libsonnet') +
-       (import 'dashboards/compactor-resources.libsonnet') +
-       (import 'dashboards/object-store.libsonnet')
-     else {}) +
-
-    (if std.member($._config.storage_engine, 'chunks')
-     then import 'dashboards/chunks.libsonnet'
-     else {}) +
-
-    (if std.member($._config.storage_engine, 'blocks')
-        && std.member($._config.storage_engine, 'chunks')
-     then import 'dashboards/comparison.libsonnet'
-     else {}) +
+    (import 'dashboards/compactor.libsonnet') +
+    (import 'dashboards/compactor-resources.libsonnet') +
+    (import 'dashboards/object-store.libsonnet') +
 
     (if !$._config.resources_dashboards_enabled then {} else
        (import 'dashboards/reads-resources.libsonnet') +

diff --git a/cortex-mixin/dashboards/chunks.libsonnet b/cortex-mixin/dashboards/chunks.libsonnet
diff --git a/cortex-mixin/dashboards/comparison.libsonnet b/cortex-mixin/dashboards/comparison.libsonnet
diff --git a/cortex-mixin/dashboards/queries.libsonnet b/cortex-mixin/dashboards/queries.libsonnet
@@ -110,23 +110,6 @@ local utils = import 'mixin-utils/utils.libsonnet';
         $.queryPanel('sum(rate(cortex_cache_corrupt_chunks_total{%s}[1m]))' % $.jobMatcher($._config.job_names.querier), 'Corrupt chunks'),
       )
     )
-    .addRowIf(
-      std.member($._config.storage_engine, 'chunks'),
-      $.row('Querier - Chunks storage - Index Cache')
-      .addPanel(
-        $.panel('Total entries') +
-        $.queryPanel('sum(querier_cache_added_new_total{cache="store.index-cache-read.fifocache",%s}) - sum(querier_cache_evicted_total{cache="store.index-cache-read.fifocache",%s})' % [$.jobMatcher($._config.job_names.querier), $.jobMatcher($._config.job_names.querier)], 'Entries'),
-      )
-      .addPanel(
-        $.panel('Cache Hit %') +
-        $.queryPanel('(sum(rate(querier_cache_gets_total{cache="store.index-cache-read.fifocache",%s}[1m])) - sum(rate(querier_cache_misses_total{cache="store.index-cache-read.fifocache",%s}[1m]))) / sum(rate(querier_cache_gets_total{cache="store.index-cache-read.fifocache",%s}[1m]))' % [$.jobMatcher($._config.job_names.querier), $.jobMatcher($._config.job_names.querier), $.jobMatcher($._config.job_names.querier)], 'hit rate')
-        { yaxes: $.yaxes({ format: 'percentunit', max: 1 }) },
-      )
-      .addPanel(
-        $.panel('Churn Rate') +
-        $.queryPanel('sum(rate(querier_cache_evicted_total{cache="store.index-cache-read.fifocache",%s}[1m]))' % $.jobMatcher($._config.job_names.querier), 'churn rate'),
-      )
-    )
     .addRow(
       $.row('Ingester')
       .addPanel(
@@ -145,30 +128,6 @@ local utils = import 'mixin-utils/utils.libsonnet';
         { yaxes: $.yaxes('short') },
       )
     )
-    .addRowIf(
-      std.member($._config.storage_engine, 'chunks'),
-      $.row('Querier - Chunks storage - Store')
-      .addPanel(
-        $.panel('Index Lookups per Query') +
-        utils.latencyRecordingRulePanel('cortex_chunk_store_index_lookups_per_query', $.jobSelector($._config.job_names.querier), multiplier=1) +
-        { yaxes: $.yaxes('short') },
-      )
-      .addPanel(
-        $.panel('Series (pre-intersection) per Query') +
-        utils.latencyRecordingRulePanel('cortex_chunk_store_series_pre_intersection_per_query', $.jobSelector($._config.job_names.querier), multiplier=1) +
-        { yaxes: $.yaxes('short') },
-      )
-      .addPanel(
-        $.panel('Series (post-intersection) per Query') +
-        utils.latencyRecordingRulePanel('cortex_chunk_store_series_post_intersection_per_query', $.jobSelector($._config.job_names.querier), multiplier=1) +
-        { yaxes: $.yaxes('short') },
-      )
-      .addPanel(
-        $.panel('Chunks per Query') +
-        utils.latencyRecordingRulePanel('cortex_chunk_store_chunks_per_query', $.jobSelector($._config.job_names.querier), multiplier=1) +
-        { yaxes: $.yaxes('short') },
-      )
-    )
     .addRowIf(
       std.member($._config.storage_engine, 'blocks'),
       $.row('Querier - Blocks storage')