Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not recurse into .git when looking for plugins #966

Merged
merged 1 commit into from
Mar 2, 2020

Conversation

ycanerol
Copy link
Contributor

@ycanerol ycanerol commented Mar 2, 2020

When using a custom plugin folder which is version controlled by git, phy recurses into all the subfolders which is unneccessary. This PR excludes paths with .git when phy is searching plugins in plugin.py

14:59:22.415 [D] plugin:74            Scanning `/home/ycan/repos/phy_plugins/.git`.
14:59:22.415 [D] plugin:74            Scanning `/home/ycan/repos/phy_plugins/.git/objects/77`.
14:59:22.415 [D] plugin:74            Scanning `/home/ycan/repos/phy_plugins/.git/objects/7a`.
14:59:22.415 [D] plugin:74            Scanning `/home/ycan/repos/phy_plugins/.git/objects/62`.
14:59:22.416 [D] plugin:74            Scanning `/home/ycan/repos/phy_plugins/.git/objects/47`.
14:59:22.416 [D] plugin:74            Scanning `/home/ycan/repos/phy_plugins/.git/objects/d0`.
14:59:22.416 [D] plugin:74            Scanning `/home/ycan/repos/phy_plugins/.git/objects/b4`.
14:59:22.416 [D] plugin:74            Scanning `/home/ycan/repos/phy_plugins/.git/objects/pack`.
14:59:22.416 [D] plugin:74            Scanning `/home/ycan/repos/phy_plugins/.git/objects/78`.
14:59:22.416 [D] plugin:74            Scanning `/home/ycan/repos/phy_plugins/.git/objects/4b`.
14:59:22.417 [D] plugin:74            Scanning `/home/ycan/repos/phy_plugins/.git/objects/01`.
14:59:22.417 [D] plugin:74            Scanning `/home/ycan/repos/phy_plugins/.git/objects/e2`.
14:59:22.417 [D] plugin:74            Scanning `/home/ycan/repos/phy_plugins/.git/objects/c1`.
14:59:22.417 [D] plugin:74            Scanning `/home/ycan/repos/phy_plugins/.git/objects/6f`.
14:59:22.417 [D] plugin:74            Scanning `/home/ycan/repos/phy_plugins/.git/objects/d4`.
14:59:22.418 [D] plugin:74            Scanning `/home/ycan/repos/phy_plugins/.git/objects/ac`.
14:59:22.418 [D] plugin:74            Scanning `/home/ycan/repos/phy_plugins/.git/objects/18`.
14:59:22.418 [D] plugin:74            Scanning `/home/ycan/repos/phy_plugins/.git/objects/37`.
14:59:22.418 [D] plugin:74            Scanning `/home/ycan/repos/phy_plugins/.git/objects/2e`.
14:59:22.418 [D] plugin:74            Scanning `/home/ycan/repos/phy_plugins/.git/objects/81`.
14:59:22.419 [D] plugin:74            Scanning `/home/ycan/repos/phy_plugins/.git/objects/25`.
14:59:22.419 [D] plugin:74            Scanning `/home/ycan/repos/phy_plugins/.git/objects/5d`.
14:59:22.419 [D] plugin:74            Scanning `/home/ycan/repos/phy_plugins/.git/objects/48`.
14:59:22.419 [D] plugin:74            Scanning `/home/ycan/repos/phy_plugins/.git/objects/info`.
14:59:22.420 [D] plugin:74            Scanning `/home/ycan/repos/phy_plugins/.git/objects/b8`.
14:59:22.420 [D] plugin:74            Scanning `/home/ycan/repos/phy_plugins/.git/objects/3d`.
14:59:22.420 [D] plugin:74            Scanning `/home/ycan/repos/phy_plugins/.git/objects/b3`.
14:59:22.420 [D] plugin:74            Scanning `/home/ycan/repos/phy_plugins/.git/objects/09`.
14:59:22.420 [D] plugin:74            Scanning `/home/ycan/repos/phy_plugins/.git/objects/52`.
14:59:22.420 [D] plugin:74            Scanning `/home/ycan/repos/phy_plugins/.git/objects/30`.
14:59:22.421 [D] plugin:74            Scanning `/home/ycan/repos/phy_plugins/.git/objects/46`.
14:59:22.421 [D] plugin:74            Scanning `/home/ycan/repos/phy_plugins/.git/objects/4d`.
14:59:22.421 [D] plugin:74            Scanning `/home/ycan/repos/phy_plugins/.git/objects/9f`.
14:59:22.421 [D] plugin:74            Scanning `/home/ycan/repos/phy_plugins/.git/objects/db`.
14:59:22.421 [D] plugin:74            Scanning `/home/ycan/repos/phy_plugins/.git/objects/fd`.
14:59:22.421 [D] plugin:74            Scanning `/home/ycan/repos/phy_plugins/.git/objects/4c`.
14:59:22.422 [D] plugin:74            Scanning `/home/ycan/repos/phy_plugins/.git/logs/refs`.
14:59:22.422 [D] plugin:74            Scanning `/home/ycan/repos/phy_plugins/.git/logs/refs/remotes`.
14:59:22.422 [D] plugin:74            Scanning `/home/ycan/repos/phy_plugins/.git/logs/refs/remotes/origin`.
14:59:22.422 [D] plugin:74            Scanning `/home/ycan/repos/phy_plugins/.git/logs/refs/heads`.
14:59:22.422 [D] plugin:74            Scanning `/home/ycan/repos/phy_plugins/.git/refs/remotes`.
14:59:22.422 [D] plugin:74            Scanning `/home/ycan/repos/phy_plugins/.git/refs/remotes/origin`.
14:59:22.423 [D] plugin:74            Scanning `/home/ycan/repos/phy_plugins/.git/refs/tags`.
14:59:22.423 [D] plugin:74            Scanning `/home/ycan/repos/phy_plugins/.git/refs/heads`.

@rossant rossant merged commit 7198b55 into cortex-lab:dev Mar 2, 2020
@rossant
Copy link
Contributor

rossant commented Mar 2, 2020

Thanks for the fix!
(note: travils currently fails because of jupyter/jupyter_client#523, should be fixed soon)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants