Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

corrosion_add_cxxbridge: Add target to regenerate bridge files #577

Merged

Conversation

LeonMatthesKDAB
Copy link
Contributor

I'm currently using CXX with Corrosion on a project that is rather difficult to build outside of a docker container and also takes a long time to build.

To get good IDE completion with clangd however, clangd needs to be able to access the header files that are generated by CXX.

This PR allows users to specify a custom CMake target that will regenerate the cxx bridges without needing to recompile.
That way, I can get good IDE completion without having to have a fully working build setup in and outside my docker container.

cmake/Corrosion.cmake Outdated Show resolved Hide resolved
cmake/Corrosion.cmake Outdated Show resolved Hide resolved
@jschwe
Copy link
Collaborator

jschwe commented Nov 13, 2024

Seems reasonable, thanks for the PR

@LeonMatthesKDAB LeonMatthesKDAB force-pushed the cxxbridge-regenerate-target-master branch from 3cb5e82 to 55111a0 Compare November 13, 2024 14:20
@LeonMatthesKDAB
Copy link
Contributor Author

@jschwe Thank you for the review. The issues you noticed should now be fixed :)

@jschwe jschwe merged commit c05ee36 into corrosion-rs:master Nov 13, 2024
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants