Fix macos-11 for CMake >= 3.19 #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Fix Corrosion on macOS >=11 by adding the necessary link directory if using the experimental parser. There is technical reason preventing a backport to the older generator (except that the property INTERFACE_LINK_DIRECTORIES requires CMake >= 3.13), so future work could add support for older CMake versions. For now I think its fine requiring a recent CMake version for recent macOS versions. Co-authored-by: Danielhu <[email protected]>
jschwe
force-pushed
the
jschwe/fix-macos11
branch
from
9d1415b to
7d7808c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Corrosion on macOS >=11 by adding the necessary link directory if
using the experimental parser. There is technical reason preventing
a backport to the older generator (except that the property
INTERFACE_LINK_DIRECTORIES requires CMake >= 3.13), so future work
could add support for older CMake versions.
For now I think its fine requiring a recent CMake version for recent
macOS versions.
Closes #104