Remove integrator buildscript #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ogoffart
approved these changes
Mar 27, 2022
jschwe
force-pushed
the
jschwe/remove-integrator-buildscript
branch
from
17d4455 to
ca52a8b
Compare
|
@ogoffart I probably should add that this is a breaking change, since I just removed the build script crate. I would just schedule this change for the next major release 0.2, since it is pretty easy to fix on the user side and overall an improvement. If you want to, I guess we could still keep the build script crate for a while. I don't think it really makes sense to add a deprecation notice though since the output of build scripts is usually not visible. |
Previously the integrator build script was needed to pass the required libraries and link search paths to cargo. However, we can do the same by directly specifying the corresponding rustflags. This makes life easier for new code, but is a breaking change, since the build script crate is just removed. Clients simply have to remove their dependency on the crate, so the migration is simple enough.
jschwe
force-pushed
the
jschwe/remove-integrator-buildscript
branch
from
ca52a8b to
233d5c1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #139
Remove the integrator buildscript and directly pass the linking arguments via
RUSTFLAGS.I'm keeping this as a separate PR (and commits) so that we can revert to the fixed build script in case removing the build script causes any problems.
Closes #54