Allow Ninja Multi-config for Cmake >= 3.20 #137
Conversation
This commit is not extensively tested, but at a first glance, Ninja Multiconfig seems to work. Signed-off-by: Jonathan Schwender <[email protected]>
jschwe
force-pushed
the
jschwe/multi-config
branch
from
eab763f to
2948aa0
Compare
|
Update: I tested this at work and Ninja Multi-Config seemed to work fine for our project. |
| @@ -240,9 +239,9 @@ function(_add_cargo_build) | |||
| set(byproducts) | |||
| foreach(byproduct_file ${ACB_BYPRODUCTS}) | |||
| list(APPEND build_byproducts "${cargo_build_dir}/${byproduct_file}") | |||
There was a problem hiding this comment.
What about this one?
There is also something similar line 154
There was a problem hiding this comment.
cargo_build_dir depends on both build_dir (which depends on $<CONFIG> for Multi-Config Generator) and on build_type_dir, which is either the cargo profile (if specified) or debug for debug builds or release for all other builds.
So the current behaviour is probably overly pessimistic and builds more seperately then it needs to.
|
I'll go ahead and merge this to master. There could of course still be some hidden issues, but since Ninja-Multiconfig is currently just disabled, I don't think this MR can really break anything. |
This commit is not extensively tested but at a first glance,
Ninja Multiconfig seems to work. I'll test this a bit more thoroughly at work tomorrow.
Closes #50