Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attempt to fix CI #120

Merged
merged 2 commits into from
Dec 30, 2021
Merged

Attempt to fix CI #120

merged 2 commits into from
Dec 30, 2021

Conversation

jschwe
Copy link
Collaborator

@jschwe jschwe commented Dec 18, 2021

  • Fix Building on Windows with Rust >= 1.57 by linking with Bcrypt.
  • Test with MacOS 10.15 instead of macos-latest, since linking on MacOS 11 currently does not work. I don't have a mac, so I'm leaving it up to someone who has one to fix building on Macos 11.

#Closes 119

@jschwe
Link Bcrypt on Windows for Rust >=1.57
d0eae73 
std depends on Bcrypt on Windows starting with rust 1.57.
See rust-lang/rust#84096.

Signed-off-by: Jonathan Schwender <[email protected]>
@jschwe
CI: Test on macos-10.15 instead of macos-latest
7b33efa 
macos-latest is now macos-11, which is currently not working. The issue
is that `ld` can't find the `System` library.
As a quick fix for the CI it makes sense to just test on the previous
version of macos, until someone finds the time to fix the linker flags
on macos-11

Signed-off-by: Jonathan Schwender <[email protected]>
@ogoffart
Copy link
Collaborator

thanks a lot.

@ogoffart ogoffart enabled auto-merge (rebase) December 19, 2021 16:11
@ogoffart
Copy link
Collaborator

i don't understand why the CI is still yellow. Looks like a github bug.

@ogoffart ogoffart closed this Dec 19, 2021
auto-merge was automatically disabled December 19, 2021 16:14

Pull request was closed

@ogoffart ogoffart reopened this Dec 19, 2021
@ogoffart
Copy link
Collaborator

Closing/re-opening restarted the CI. Let's see what happens.

@ogoffart
Copy link
Collaborator

It looks like there if still one job using macos-latest that does not work.
Also the matrix is a bit big and we probably should reduce it.

@jschwe
Copy link
Collaborator Author

jschwe commented Dec 20, 2021

It looks like there if still one job using macos-latest that does not work. Also the matrix is a bit big and we probably should reduce it.

Could you go to "Settings" (of this repository) and then to "Branches" / "Require status checks to pass before merging" and remove the macos-latest jobs from that list?

In my fork it looks something like this:
grafik

@ogoffart
Copy link
Collaborator

I don't have the rights to do that.
@AndrewGaspar , can you please do it?

@jschwe jschwe force-pushed the jschwe/fix-CI branch 2 times, most recently from a032f5c to 7b33efa Compare December 30, 2021 10:59
@jschwe
Copy link
Collaborator Author

jschwe commented Dec 30, 2021

@AndrewGaspar Could you also do this for the remaining two required jobs:

  • Test Corrosion as a Library (macos-latest, install)
  • Test Corrosion as a Library (macos-latest, subdirectory)

On a related note: It seems that the failing macos-latest CI tests do work if you use CMake 3.19. I don't have a Mac so I can't really say anything more than that.

@ogoffart
Copy link
Collaborator

I don't even know where the Test Corrosion as a Library (macos-latest, install) and Test Corrosion as a Library (macos-latest, subdirectory) tests comes from. It's not in the github action.
I now have the privilege to merge this so i'll do that.
Thanks for your help.

@ogoffart ogoffart merged commit c49ab0c into corrosion-rs:master Dec 30, 2021
@jschwe jschwe mentioned this pull request Dec 30, 2021
Closed
@djmitche djmitche mentioned this pull request Feb 27, 2022
Merged
@jschwe jschwe deleted the jschwe/fix-CI branch September 7, 2022 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jschwe @ogoffart