Initial commit to build on ARM #99
Conversation
SalusaSecondus
force-pushed
the
arm
branch
2 times, most recently
from
c84304c to
bd97448
Compare
|
Closing and re-opening to force re-run of checks (now that they have |
There was a problem hiding this comment.
The license headers should be updated. You can update the individual files to remove the date, or you need to update the date to the current year.
// Copyright Amazon.com Inc. or its affiliates. All Rights Reserved.
// SPDX-License-Identifier: Apache-2.0
We should have a big PR to update all the files to avoid this.
| @@ -4,6 +4,7 @@ | |||
|
|
|||
| ### Improvements | |||
| * Now uses [OpenSSL 1.1.1f](https://www.openssl.org/source/openssl-1.1.1f.tar.gz). [PR #97](https://github.com/corretto/amazon-corretto-crypto-provider/pull/97) | |||
| * **EXPERIMENTAL** support for aarch64 added. [PR #99](https://github.com/corretto/amazon-corretto-crypto-provider/pull/99) | |||
There was a problem hiding this comment.
I would suggest moving to something like https://www.conventionalcommits.org/en/v1.0.0/ to handle this.
Out of scope for this PR, just a note.
There was a problem hiding this comment.
We are not changing our versioning of ACCP at this time.
| add_custom_target(check-rdrand | ||
| COMMAND $<TARGET_FILE:test_rdrand> | ||
| ) | ||
| add_dependencies(check check-rdrand) |
There was a problem hiding this comment.
Does this mean you are adding check twice? Here and below?
There was a problem hiding this comment.
No. The first element check is getting a new dependency check-rdrand.
| @@ -716,6 +723,8 @@ add_custom_target(run-benchmark | |||
|
|
|||
| set_target_properties(run-benchmark PROPERTIES EXCLUDE_FROM_ALL 1) | |||
|
|
|||
| if (CMAKE_SYSTEM_PROCESSOR STREQUAL "x86_64") | |||
There was a problem hiding this comment.
Everything under this is not re-indented, is this intentional?
Also, you have a comment at the end # End of Dieharder targets, would it be good to have one at the beginning?
There was a problem hiding this comment.
I'll change the closing comment to # End of x64_64 only targets
Issue #, if available: #40
Description of changes:
Changes necessary to support ARM64/aarch64.
This does not include changes to our build/publishing system and so will not publish to maven or otherwise release these artifacts.
Additionally, as standardized support for hardware entropy is not yet common on aarch64, this version disables the build-in implementation of
SecureRandom. This is identical behavior to ACCP on x86_64 systems lackingRDRAND.This commit includes a patch file from openssl/openssl#10842 with special thanks to @sztomi who graciously released his patch under the MIT license.
As our integrated tests do not (currently) run on
aarch64, I have run the following commands locally on myaarch64ec2 instance and all have been successfull../gradlew clean./gradlew release./gradlew test_integration./gradlew test_extra_checks test_integration_extra_checksBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.