Initial Import of AWS-LC Cryptofuzz CI #342
Conversation
| # codebuild_$identifier. | ||
| # https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-codebuild-project-projectfilesystemlocation.html | ||
| # | ||
| # TODO: add this to the CDK project above when it supports EfsFileSystemLocation |
There was a problem hiding this comment.
note for later PR: does CDK support this now?
| fi | ||
| } | ||
|
|
||
| function build_and_test_ssl_runner_valgrind { |
There was a problem hiding this comment.
note for later PR: a lot of the stuff in this file seems AWS-LC-specific. we should prune out what we can.
There was a problem hiding this comment.
Yup, you'll see that in the next PR.
| @@ -0,0 +1,19 @@ | |||
| # Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved. | |||
There was a problem hiding this comment.
what's this dockerfile used for?
There was a problem hiding this comment.
As a layer that has clang installed/configured for the cryptofuzz container. In LC, they use it for other stuff but if we are inclined we can flatten the hierarchy a bit to avoid this. Layering is best practice within the Docker ecosystem though.
There was a problem hiding this comment.
no objections to layering, but it looks like tests/ci/docker_images/linux-x86/amazonlinux-2_clang-11x_cryptofuzz/Dockerfile doesn't depend on this or images produced by it, instead referencing amazonlinux-2023:clang-15x
(no need to address until next PR in the series)
There was a problem hiding this comment.
This PR is direct copy of the source material (with some file renaming to make things diff better). The next PR updates the references.
tests/ci/docker_images/linux-x86/amazonlinux-2_clang-11x_cryptofuzz/Dockerfile
Show resolved
Hide resolved
| # Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved. | ||
| # SPDX-License-Identifier: Apache-2.0 OR ISC | ||
|
|
||
| FROM amazonlinux-2023:clang-15x |
There was a problem hiding this comment.
the file is amazonlinux-2_clang-11x_cryptofuzz but we're basing this on amazonlinux-2023:clang-15x. is the file misnamed?
(no need to address until next PR in the series)
This directly imports the related CI source for Cryptofuzz from AWS-LC so that the ACCP specific changes show up better in PR and the source history.
Issue #, if available:
CryptoAlg-2133
Description of changes:
This imports a pristine copy of the AWS-LC Cryptofuzz CI infrastructure so that
it'll be a lot easier to review the changes made to support ACCP.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.