Do not destroy linked public keys #335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SalusaSecondus
force-pushed
the
destroy
branch
3 times, most recently
from
559beee
to
cd87f3e
Compare
geedo0
previously approved these changes
Oct 6, 2023
Comment on lines
231
to
233
| if (isDestroyed()) { | ||
| throw new IllegalStateException("Already destroyed"); | ||
| } |
There was a problem hiding this comment.
nit: You can reuse your assertNotDestroyed method here.
There was a problem hiding this comment.
Oops. Missed one. Thank you.
SalusaSecondus
force-pushed
the
destroy
branch
2 times, most recently
from
f993fbb
to
0e06f65
Compare
SalusaSecondus
force-pushed
the
destroy
branch
from
0e06f65
to
3f26de3
Compare
geedo0
approved these changes
Oct 30, 2023
amirhosv
approved these changes
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ACCP private keys currently support destruction to make it easier to clean up sensitive data from memory. Currently the logic has three issues which need to be fixed:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.