Ignore expired certs in tests #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SalusaSecondus
added
the
test improvement
|
so, how do we notice when tests are skipping due to cert expiration? this feels like it could open the door to regressions creeping in around cert validations... |
|
The logs are how we'd notice it (ideally). We're still using the certificates which is where the most interesting cryptography is. Validating the signature on them is relatively boring. |
SalusaSecondus
force-pushed
the
ignore_expiration
branch
from
7988a7b
to
1688266
Compare
WillChilds-Klein
approved these changes
Apr 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
External integration tests now skip certificate validation for expired certificates. This is to work around external sites which may have allowed their certificates to expire.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.