Decrease the timing differences when trimming zeros from DH TLS PMS #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scottarc
approved these changes
Sep 15, 2020
| /** | ||
| * Equivalent to {@code val != 0 ? 1 : 0} | ||
| */ | ||
| static final int isNonZero(int val) { |
There was a problem hiding this comment.
Very minor bikeshed: Is it possible to use byte as the return type instead of int to save on memory usage? (If the answer is "No", that's fine.)
There was a problem hiding this comment.
Technically, yes.
However, Java automatically casts all bit-wise operations to int or larger. So, I'm not sure if it would practically decrease memory usage and it would make everything a bit more annoying to read (due to large numbers of casts).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
These changes reduce the timing signal generated by trimming zeros from DH agreed TLS pre-master secrets. They cannot be fully eliminated, but these changes help mitigate them.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.