Do not modify output when Cipher.doFinal fails #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would like to have two people review this change. I can be one of them though if you find two other people before I manage to look at this, feel free to merge. My reasoning for 2-person review is that we've made a mistake in this critical logic once already (presumably we didn't intend to have the behavior we are fixing) and I'd like to reduce the likelihood of another mistake :-). |
scottarc
approved these changes
Sep 1, 2020
praus
approved these changes
Sep 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
This change modifies
Cipher.doFinalsuch that when an exception is thrown the out-parameter remain unchanged.The diff appears to be choking on some indentation changes and thinking this is a bigger change than it appears. I strongly recommend that viewers select the "ignore white-space" option when reviewing this PR as it makes the change much easier to see and read.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.