-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow use of node 16 in CI #48
Conversation
Boost.Test failures should be fixed by: boostorg/test#421 |
Ok, thanks! do I wait for the fix in Boost.Test to be merged? |
I just merged the fix into Boost.Test develop branch so it should be good now. |
mmm, still getting an error. not sure if I rerun the workflow too early https://github.com/correaa/boost-multi/actions/runs/9841457410/job/27182984846 |
It's possible. I also have the patch cycling to merge into master: boostorg/test#422, in case that is what you are pulling from. |
The linked PR for test has been merged. Give it like 20 mins for the super project bot to pick up the commit and then hopefully this will run green. |
the codecov/posix workflow is still picking the Boost.Test problem. |
I'm not sure what that one is building off of. It looks like it should be master since it says version 1.86 (the next one), and master picked up the changes: boostorg/boost@3de5c2f. Do you have Codecov running fine on your Gitlab CI? If so we could disable the GitHub one for now. |
We could do that, yes. Codecov is working on gitlab. Is this codecov being even reported somewhere? |
From the most recent passing run looks like the answer is no: https://github.com/correaa/boost-multi/actions/runs/9719653836/job/26829810460#step:14:113. |
Everything is back to green now |
GHA has changed the default node version breaking builds. Allow the use of node16 since node20 (the new default) does not work.