Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow use of node 16 in CI #48

Merged
merged 2 commits into from
Jul 9, 2024
Merged

Allow use of node 16 in CI #48

merged 2 commits into from
Jul 9, 2024

Conversation

mborland
Copy link
Contributor

@mborland mborland commented Jul 8, 2024

GHA has changed the default node version breaking builds. Allow the use of node16 since node20 (the new default) does not work.

@mborland
Copy link
Contributor Author

mborland commented Jul 8, 2024

Boost.Test failures should be fixed by: boostorg/test#421

@correaa
Copy link
Owner

correaa commented Jul 8, 2024

Ok, thanks!

do I wait for the fix in Boost.Test to be merged?

@mborland
Copy link
Contributor Author

mborland commented Jul 8, 2024

Ok, thanks!

do I wait for the fix in Boost.Test to be merged?

I just merged the fix into Boost.Test develop branch so it should be good now.

@correaa
Copy link
Owner

correaa commented Jul 8, 2024

mmm, still getting an error. not sure if I rerun the workflow too early https://github.com/correaa/boost-multi/actions/runs/9841457410/job/27182984846

@mborland
Copy link
Contributor Author

mborland commented Jul 8, 2024

mmm, still getting an error. not sure if I rerun the workflow too early https://github.com/correaa/boost-multi/actions/runs/9841457410/job/27182984846

It's possible. I also have the patch cycling to merge into master: boostorg/test#422, in case that is what you are pulling from.

@mborland
Copy link
Contributor Author

mborland commented Jul 9, 2024

mmm, still getting an error. not sure if I rerun the workflow too early https://github.com/correaa/boost-multi/actions/runs/9841457410/job/27182984846

It's possible. I also have the patch cycling to merge into master: boostorg/test#422, in case that is what you are pulling from.

The linked PR for test has been merged. Give it like 20 mins for the super project bot to pick up the commit and then hopefully this will run green.

@correaa
Copy link
Owner

correaa commented Jul 9, 2024

the codecov/posix workflow is still picking the Boost.Test problem.

https://github.com/correaa/boost-multi/actions/runs/9841457410/job/27182984846?pr=48#step:12:134

@mborland
Copy link
Contributor Author

mborland commented Jul 9, 2024

the codecov/posix workflow is still picking the Boost.Test problem.

https://github.com/correaa/boost-multi/actions/runs/9841457410/job/27182984846?pr=48#step:12:134

I'm not sure what that one is building off of. It looks like it should be master since it says version 1.86 (the next one), and master picked up the changes: boostorg/boost@3de5c2f. Do you have Codecov running fine on your Gitlab CI? If so we could disable the GitHub one for now.

@correaa
Copy link
Owner

correaa commented Jul 9, 2024

the codecov/posix workflow is still picking the Boost.Test problem.
https://github.com/correaa/boost-multi/actions/runs/9841457410/job/27182984846?pr=48#step:12:134

I'm not sure what that one is building off of. It looks like it should be master since it says version 1.86 (the next one), and master picked up the changes: boostorg/boost@3de5c2f. Do you have Codecov running fine on your Gitlab CI? If so we could disable the GitHub one for now.

We could do that, yes. Codecov is working on gitlab.

Is this codecov being even reported somewhere?

@mborland
Copy link
Contributor Author

mborland commented Jul 9, 2024

Is this codecov being even reported somewhere?

From the most recent passing run looks like the answer is no: https://github.com/correaa/boost-multi/actions/runs/9719653836/job/26829810460#step:14:113.

@mborland
Copy link
Contributor Author

mborland commented Jul 9, 2024

Everything is back to green now

@correaa correaa merged commit c96b1a3 into correaa:master Jul 9, 2024
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants