-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update header: Add end of development banner #3436
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me in general, one text suggestion!
This comment was marked as resolved.
This comment was marked as resolved.
The banner text was intended to be shorter so that it wouldn't take up more space than needed, especially on mobile. I'd say the wording is similar enough. For comparison: EN: DE: |
@larswmh / @MikeMcC399 Is both grammatically correct? "You still can warn […]" vs. "You can still warn […]" |
Both are correct. The difference of word order causes a change in emphasis. |
Thanks for the reviews @MikeMcC399 & @Ein-Tim. I'm going to merge this into the |
Will you also open a PR against update/eod now in case there are any remaining comments not covered in the individual PRs flowing into this branch? |
This PR adds a banner above the header that links to the explanatory FAQ entries about the end of development of the Corona-Warn-App.
Screenshots:
Desktop EN:
coronawarn.app/en
coronawarn.app/en/faq
Desktop DE:
coronawarn.app/de
coronawarn.app/de/faq
Mobile EN:
coronawarn.app/en
coronawarn.app/en/faq
Mobile DE:
coronawarn.app/de
coronawarn.app/de/faq
Internal Tracking ID: EXPOSUREAPP-14582