Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dashboard: Add annotations for Warning without TAN #3434

Merged
merged 5 commits into from
Mar 23, 2023

Conversation

larswmh
Copy link
Member

@larswmh larswmh commented Mar 22, 2023

This PR adds an annotation to the dashboard to show when "Warning without TAN" was implemented into the app. This will help to understand why the statistics in the lower two tiles have significantly changed after this date.

image


Internal Tracking ID: EXPOSUREAPP-14711

@larswmh larswmh requested a review from a team March 22, 2023 10:01
@larswmh larswmh self-assigned this Mar 22, 2023
@MikeMcC399
Copy link
Contributor

@larswmh

This is a good for the first transition, however it would need also the second transition on March 1, 2023 to be flagged as well.

image

After March 1, 2023 significantly less tests are being done due to legal changes in TestV. See also #3415.

Otherwise it would be difficult to interpret and understand the peak and drop-off of numbers.

@larswmh
Copy link
Member Author

larswmh commented Mar 23, 2023

@MikeMcC399

This is a good for the first transition, however it would need also the second transition on March 1, 2023 to be flagged as well.

image

After March 1, 2023 significantly less tests are being done due to legal changes in TestV. See also #3415.

Otherwise it would be difficult to interpret and understand the peak and drop-off of numbers.

We agree that there should be another annotation for the legal changes in TestV. We already forwarded your suggestion yesterday and got positive feedback. This will be added in a PR soon, however we would like to merge this PR now.

@MikeMcC399
Copy link
Contributor

@larswmh

We agree that there should be another annotation for the legal changes in TestV. We already forwarded your suggestion yesterday and got positive feedback. This will be added in a PR soon, however we would like to merge this PR now.

Many thanks for picking up my suggestion!

I would personally want to add the two annotations together, but of course it's your decision if you want to go ahead with this PR on its own.

@larswmh larswmh merged commit a49d744 into master Mar 23, 2023
@larswmh larswmh deleted the srs-graph-annotations branch March 23, 2023 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants