Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review & Update the "Ursache 3, API 10" FAQ entry #3419

Merged
merged 3 commits into from
Mar 14, 2023
Merged

Review & Update the "Ursache 3, API 10" FAQ entry #3419

merged 3 commits into from
Mar 14, 2023

Conversation

brianebeling
Copy link
Member

Fixes #3069

@brianebeling brianebeling requested a review from a team March 7, 2023 11:19
@brianebeling brianebeling self-assigned this Mar 7, 2023
GisoSchroederSAP
GisoSchroederSAP approved these changes Mar 14, 2023
View reviewed changes
Copy link
Contributor

@GisoSchroederSAP GisoSchroederSAP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we refer to the already existing article, this seems to be fine!
Approved, please go ahead.

MikeMcC399
MikeMcC399 suggested changes Mar 14, 2023
View reviewed changes
Copy link
Contributor

@MikeMcC399 MikeMcC399 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://developer.mozilla.org/en-US/docs/Web/HTML/Element/hr#technical_summary

Tag omission | It must have start tag, but must not have an end tag.

</hr> is an end tag and is therefore illegal HTML

@brianebeling brianebeling requested a review from MikeMcC399 March 14, 2023 15:23
@brianebeling brianebeling merged commit 1d1ab66 into master Mar 14, 2023
@brianebeling brianebeling deleted the reason-3-api-10-faq branch March 14, 2023 16:01
@larswmh larswmh mentioned this pull request Mar 28, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GisoSchroederSAP GisoSchroederSAP GisoSchroederSAP approved these changes

@MikeMcC399 MikeMcC399 MikeMcC399 approved these changes

Assignees

@brianebeling brianebeling

Labels
faq
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Review & Update the "Ursache 3, API 10" FAQ entry
3 participants
@brianebeling @MikeMcC399 @GisoSchroederSAP