Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude buergertest.ecocare.center from link test #3418

Merged
merged 1 commit into from
Mar 8, 2023
Merged

Exclude buergertest.ecocare.center from link test #3418

merged 1 commit into from
Mar 8, 2023

Conversation

MikeMcC399
Copy link
Contributor

$ curl -I https://buergertest.ecocare.center/#c734
HTTP/2 404
x-ua-compatible: IE=edge
content-type: text/html; charset=utf-8
date: Tue, 07 Mar 2023 08:20:57 GMT
server: Apache

@MikeMcC399 MikeMcC399 marked this pull request as ready for review March 7, 2023 09:11
@MikeMcC399 MikeMcC399 requested a review from a team March 7, 2023 09:11
@brianebeling brianebeling self-assigned this Mar 7, 2023
@brianebeling brianebeling added bug Something isn't working in review Moderators are investigating how to best proceed with the issue labels Mar 7, 2023
@MikeMcC399
Copy link
Contributor Author

@brianebeling

This would be a quick, easy and relatively clean fix. I don't think it is worth spending too much time on making a decision on this. There are currently more important issues to be resolved.

@brianebeling
Copy link
Member

brianebeling commented Mar 8, 2023

Brian-J. Ebeling

This would be a quick, easy and relatively clean fix. I don't think it is worth spending too much time on making a decision on this. There are currently more important issues to be resolved.

Hey Mike, its not that I'm spending a lot of time on this, more so that I don't want to be hasty, because there is a lot to do. I already noticed that leads to bad decisions.

I was also waiting for an answer from other participants, if we can make an exception updating the blogs in this case. The answer is yes, we can. However, I'd say we merge this PR and wait for the banner indicating EOL. Then we don't need to change the blogs at all, for now. (unless another link gets hijacked again, in this case I advocate to just remove it)

@brianebeling brianebeling merged commit 0194ad1 into corona-warn-app:master Mar 8, 2023
@brianebeling brianebeling removed in review Moderators are investigating how to best proceed with the issue bug Something isn't working labels Mar 8, 2023
@MikeMcC399 MikeMcC399 deleted the fix/ecocare-link-alternative branch March 8, 2023 13:25
@larswmh larswmh mentioned this pull request Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants