-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Work around Cypress GPU error #3381
Conversation
Any idea why it does now? |
Whenever the ERROR message is displayed the test continues successfully. That has not changed. The only change is that I now understood better about the reason behind the error message and how to prevent it occurring. The PR prevents the error occurring when a browser apart from Electron is selected to run the Cypress tests. Edit: I changed the wording so that it is clearer that the error never stops the test. |
You're right, sorry for the misleading comment! I was just confused cause the Cypress production test failed in my repo today: https://github.com/Ein-Tim/cwa-website/actions/runs/4155601424/jobs/7188810639
Thank you very much for taking care of it! Have a nice Sunday! |
No problem!
There can be temporary conditions which cause the test to fail. You should be able to select it to re-run manually if you go to https://github.com/Ein-Tim/cwa-website/actions/workflows/cypress-test-prod.yml |
Thanks for the PR @MikeMcC399! |
This PR works around the error:
showing in the log files of
The error is caused when the Electron browser, built-in to Cypress, attempts to make use of graphics hardware acceleration, which is not available in the GitHub runner virtual environment.
The PR adds the environment variable to prevent this error message appearing:
(The error has never prevented the Cypress test from completing successfully.)
Verification
Run the workflow .github/workflows/cypress-test-prod.yml and confirm that the workflow continues to succeed and that there is no gpu related error message in the logs.
The workflow .github/workflows/build-and-test.yml is automatically run on
pull_request
. Similarly check for success and absence of any gpu related error message.Other references
Internal Tracking ID: EXPOSUREAPP-14770