Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work around Cypress GPU error #3381

Merged
merged 1 commit into from
Feb 13, 2023
Merged

Work around Cypress GPU error #3381

merged 1 commit into from
Feb 13, 2023

Conversation

MikeMcC399
Copy link
Contributor

@MikeMcC399 MikeMcC399 commented Feb 12, 2023

This PR works around the error:

[2134:0211/090347.983213:ERROR:gpu_memory_buffer_support_x11.cc(44)] dri3 extension not supported.

showing in the log files of

The error is caused when the Electron browser, built-in to Cypress, attempts to make use of graphics hardware acceleration, which is not available in the GitHub runner virtual environment.

The PR adds the environment variable to prevent this error message appearing:

env:
  ELECTRON_EXTRA_LAUNCH_ARGS: '--disable-gpu'

(The error has never prevented the Cypress test from completing successfully.)

Verification

Run the workflow .github/workflows/cypress-test-prod.yml and confirm that the workflow continues to succeed and that there is no gpu related error message in the logs.

The workflow .github/workflows/build-and-test.yml is automatically run on pull_request. Similarly check for success and absence of any gpu related error message.

Other references


Internal Tracking ID: EXPOSUREAPP-14770

@MikeMcC399 MikeMcC399 requested a review from a team February 12, 2023 09:07
@MikeMcC399 MikeMcC399 marked this pull request as draft February 12, 2023 09:17
@MikeMcC399 MikeMcC399 marked this pull request as ready for review February 12, 2023 10:06
@Ein-Tim
Copy link
Contributor

Ein-Tim commented Feb 12, 2023

The error did not previously prevent the Cypress test from completing successfully.

Any idea why it does now?

@MikeMcC399
Copy link
Contributor Author

MikeMcC399 commented Feb 12, 2023

@Ein-Tim

The error did not previously prevent the Cypress test from completing successfully.

Any idea why it does now?

Whenever the ERROR message is displayed the test continues successfully. That has not changed.

The only change is that I now understood better about the reason behind the error message and how to prevent it occurring.

The PR prevents the error occurring when a browser apart from Electron is selected to run the Cypress tests.

Edit: I changed the wording so that it is clearer that the error never stops the test.

@Ein-Tim
Copy link
Contributor

Ein-Tim commented Feb 12, 2023

@MikeMcC399

Whenever the ERROR message is displayed the test continues successfully. That has not changed.

You're right, sorry for the misleading comment! I was just confused cause the Cypress production test failed in my repo today: https://github.com/Ein-Tim/cwa-website/actions/runs/4155601424/jobs/7188810639

The PR prevents the error occurring when a browser apart from Electron is selected to run the Cypress tests.

Thank you very much for taking care of it!

Have a nice Sunday!

@MikeMcC399
Copy link
Contributor Author

@Ein-Tim

You're right, sorry for the misleading comment!

No problem!

I was just confused cause the Cypress production test failed in my repo today: https://github.com/Ein-Tim/cwa-website/actions/runs/4155601424/jobs/7188810639

There can be temporary conditions which cause the test to fail. You should be able to select it to re-run manually if you go to https://github.com/Ein-Tim/cwa-website/actions/workflows/cypress-test-prod.yml

@larswmh
Copy link
Member

larswmh commented Feb 13, 2023

Thanks for the PR @MikeMcC399!

@larswmh larswmh merged commit 7e2b9a3 into corona-warn-app:master Feb 13, 2023
@MikeMcC399 MikeMcC399 deleted the fix/gpu-error branch February 13, 2023 08:17
@MikeMcC399 MikeMcC399 mentioned this pull request Feb 13, 2023
@larswmh larswmh mentioned this pull request Feb 14, 2023
21 tasks
Ein-Tim pushed a commit to Ein-Tim/cwa-website that referenced this pull request Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants