Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add short Cypress test script npm run test:short #3309

Merged
merged 2 commits into from
Jan 5, 2023
Merged

Add short Cypress test script npm run test:short #3309

merged 2 commits into from
Jan 5, 2023

Conversation

MikeMcC399
Copy link
Contributor

@MikeMcC399 MikeMcC399 commented Jan 5, 2023

This PR implements one suggestion from #3308 "Improve testing for PR submission".

It provides a new script which can be run with:

npm run test:short

This runs all Cypress tests except cypress/e2e/hybrid/check_links.cy.js.

Verification

Execute

npm run test:short

and confirm that there are no errors reported.


Internal Tracking ID: EXPOSUREAPP-14530

@MikeMcC399 MikeMcC399 requested a review from a team January 5, 2023 07:02
@MikeMcC399 MikeMcC399 marked this pull request as draft January 5, 2023 07:34
@MikeMcC399

This comment was marked as resolved.

Implement npm run test:short script in package.json
Document in README
@MikeMcC399 MikeMcC399 marked this pull request as ready for review January 5, 2023 07:59
@MikeMcC399
Copy link
Contributor Author

npm run test:short is successful on:

  • Ubuntu 22.04
  • Windows 11

with Node.js 18.12.1

Perhaps somebody would be kind enough to test it on macOS? @Ein-Tim? @larswmh?

Copy link
Member

@larswmh larswmh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

macOS Ventura 13.1, Apple M1 Pro
Node.js 18.12.1

image

package.json Outdated Show resolved Hide resolved
@dsarkar
Copy link
Member

dsarkar commented Jan 5, 2023

@MikeMcC399 Many thanks for this PR. (On my older 2.7 GHz i5 Mac the test still takes about 10 min...)

@larswmh larswmh merged commit 1885ba9 into corona-warn-app:master Jan 5, 2023
@MikeMcC399 MikeMcC399 deleted the feat/short-test branch January 5, 2023 09:23
@MikeMcC399
Copy link
Contributor Author

MikeMcC399 commented Jan 5, 2023

@dsarkar

Many thanks for this PR.

You're welcome!

(On my older 2.7 GHz i5 Mac the test still takes about 10 min...)

The run time is quite dependent on the available hardware. On my Windows 11 laptop (SSD drive, intel i5, 8GB) the Cypress test shows "All specs passed 02:47". The screenshot from @larswmh was even faster with 01:24.

Maybe you need to speak to someone nicely to get a hardware upgrade sometime? 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants