Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Npm full update #3296

Merged
merged 6 commits into from
Dec 23, 2022
Merged

Npm full update #3296

merged 6 commits into from
Dec 23, 2022

Conversation

brianebeling
Copy link
Member

@brianebeling brianebeling commented Dec 21, 2022 •
edited by dsarkar
Loading

This is a followup to #3295 and updates more packages using the npm update method. So far I have not found something that broke.

#3295 should be merged prior to this, since this PR is based on the work of #3295

Internal Tracking ID: EXPOSUREAPP-14497

@brianebeling brianebeling requested a review from a team December 21, 2022 17:29
@brianebeling brianebeling added the dependencies Pull requests that update a dependency file label Dec 21, 2022
@brianebeling brianebeling mentioned this pull request Dec 21, 2022
Closed
MikeMcC399
MikeMcC399 suggested changes Dec 21, 2022
View reviewed changes
Copy link
Contributor

@MikeMcC399 MikeMcC399 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@brianebeling

I would suggest to run
npm update --save

and then commit both package.json and package-lock.json

@dsarkar dsarkar self-requested a review December 23, 2022 09:27
@dsarkar dsarkar merged commit 3161265 into master Dec 23, 2022
@MohamedZaghdoudi MohamedZaghdoudi mentioned this pull request Jan 13, 2023
Closed
@dsarkar dsarkar deleted the update-dependencies-npm-update branch February 2, 2023 11:50
@brianebeling brianebeling mentioned this pull request Feb 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MikeMcC399 MikeMcC399 MikeMcC399 requested changes

@dsarkar dsarkar dsarkar approved these changes

Assignees

@dsarkar dsarkar

Labels
dependencies Pull requests that update a dependency file mirrored-to-jira technical-issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brianebeling @dsarkar @MikeMcC399