This repository has been archived by the owner on May 16, 2023. It is now read-only.
typo (securiy -> security) #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ckuelker
requested review from
alstiefel,
ascheibal,
jhagestedt,
kreincke and
tence
as code owners
CCFenner
reviewed
Jun 4, 2020
| @@ -152,7 +152,7 @@ Data is deleted after 90 days. | |||
|
|
|||
| |Role| Authentication |Comment| | |||
| | ------------- |:-------------:| -----:| | |||
| |GW to connected Labs (/lab/result Endpoint) | TLS Client Certificate, 2nd factor IP Range | Endpoint is exposed to an other securiy zone | |||
| |GW to connected Labs (/lab/result Endpoint) | TLS Client Certificate, 2nd factor IP Range | Endpoint is exposed to an other security zone | |||
There was a problem hiding this comment.
let's fix this as well...
Suggested change
| |GW to connected Labs (/lab/result Endpoint) | TLS Client Certificate, 2nd factor IP Range | Endpoint is exposed to an other security zone | |
| |GW to connected Labs (/lab/result Endpoint) | TLS Client Certificate, 2nd factor IP Range | Endpoint is exposed to another security zone |
edit: I guess both is valid depending on the intended meaning.
There was a problem hiding this comment.
The string 'an other' is vanishingly rare in English. In contrast 'another' is positively pervasive. However, could it be that 'any other' is meant? See: https://english.stackexchange.com/questions/56435/an-other-vs-another
There was a problem hiding this comment.
Notwithstanding, 'another', 'an other' or 'any other' is not a typo and probably should not be part of this pull request as this request has the subject 'typo' and no intention to change the meaning, imo.
daniel-eder
approved these changes
Jun 5, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
just a typo 'securiy' should be written 'security'