Skip to content
This repository has been archived by the owner on May 16, 2023. It is now read-only.

Remove missing .yaml attribute validation test #652

Merged
merged 3 commits into from
Jul 6, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,6 @@ public enum ErrorType {
VALUE_OUT_OF_BOUNDS,
INVALID_URL,
INVALID_PARTITIONING,
TOO_MANY_DECIMAL_PLACES,
MISSING_ENTRY
TOO_MANY_DECIMAL_PLACES
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@

import static app.coronawarn.server.services.distribution.assembly.appconfig.validation.ExposureConfigurationValidator.CONFIG_PREFIX;
import static app.coronawarn.server.services.distribution.assembly.appconfig.validation.RiskScoreClassificationValidatorTest.buildError;
import static app.coronawarn.server.services.distribution.assembly.appconfig.validation.ValidationError.ErrorType.MISSING_ENTRY;
import static app.coronawarn.server.services.distribution.assembly.appconfig.validation.ValidationError.ErrorType.TOO_MANY_DECIMAL_PLACES;
import static app.coronawarn.server.services.distribution.assembly.appconfig.validation.ValidationError.ErrorType.VALUE_OUT_OF_BOUNDS;
import static org.assertj.core.api.Assertions.assertThat;
Expand Down Expand Up @@ -69,8 +68,6 @@ private static Stream<Arguments> createOkTests() {
private static Stream<Arguments> createFailedTests() {
return Stream.of(
ScoreTooHigh(),
// TODO cwa-server/#320 Validate that no attributes are missing in .yaml
// ScoreNegative(),
WeightNegative(),
WeightTooHigh()
).map(Arguments::of);
Expand Down Expand Up @@ -103,12 +100,6 @@ public static TestWithExpectedResult WeightTooHigh() {
.with(buildError(CONFIG_PREFIX + "transmission", 101d, VALUE_OUT_OF_BOUNDS));
}

public static TestWithExpectedResult ScoreNegative() {
return new TestWithExpectedResult("score_negative.yaml")
.with(buildError(CONFIG_PREFIX + "transmission.appDefined1", RiskLevel.UNRECOGNIZED, VALUE_OUT_OF_BOUNDS))
.with(buildError(CONFIG_PREFIX + "transmission.appDefined3", null, MISSING_ENTRY));
}

public static TestWithExpectedResult ScoreTooHigh() {
return new TestWithExpectedResult("score_too_high.yaml")
.with(buildError(CONFIG_PREFIX + "transmission.appDefined1", RiskLevel.UNRECOGNIZED, VALUE_OUT_OF_BOUNDS))
Expand Down

This file was deleted.