Enchantments - Increase test coverage

services/submission/src/main/java/app/coronawarn/server/services/submission/validation/ValidSubmissionPayload.java

@@ -88,11 +88,6 @@ public boolean isValid(SubmissionPayload submissionPayload, ConstraintValidatorC
       List<TemporaryExposureKey> exposureKeys = submissionPayload.getKeysList();
       validatorContext.disableDefaultConstraintViolation();
 
-      if (Objects.isNull(exposureKeys)) {
-        addViolation(validatorContext, "Field 'keys' points to Null.");
-        return false;
-      }
-
       boolean isValid = checkKeyCollectionSize(exposureKeys, validatorContext);
       isValid &= checkUniqueStartIntervalNumbers(exposureKeys, validatorContext);
       isValid &= checkNoOverlapsInTimeWindow(exposureKeys, validatorContext);

services/submission/src/test/java/app/coronawarn/server/services/submission/monitoring/VerificationServiceHealthIndicatorTest.java

@@ -57,12 +57,19 @@ public void setup() {
   }
 
   @Test
-  void checkIsHealthyIfVerificationServerIsRunning() throws Exception {
+  void checkIsHealthyIfVerificationServerIsRunningAndExceptionIsThrown() throws Exception {
     when(verificationServerClient.verifyTan(any())).thenThrow(FeignException.NotFound.class);
     mvc.perform(get("/actuator/health"))
         .andExpect(status().is2xxSuccessful()).andReturn();
   }
 
+  @Test
+  void checkIsHealthyIfVerificationServerIsRunning() throws Exception {
+    when(verificationServerClient.verifyTan(any())).thenReturn("ok");
+    mvc.perform(get("/actuator/health"))
+        .andExpect(status().is2xxSuccessful()).andReturn();
+  }
+
   @Test
   void checkIsUnhealthyIfVerificationServerIsDown() throws Exception {
     when(verificationServerClient.verifyTan(any())).thenThrow(FeignException.InternalServerError.class);