This repository has been archived by the owner on May 16, 2023. It is now read-only.
remove use of ForkJoinPool in SubmissionController (closes #399) #495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nils4cosee
requested review from
christian-kirschnick,
johanneseschrig,
michael-burwig,
MKusber,
ole-lilienthal,
pithumke,
stevesap and
UnchartedBull
as code owners
Closed
While a scheduled-executor makes sense for timing the response to fake-requests, real requests should better be handled in the web-thread directly. We still use the DeferredResult to as response, but do not run real requests in new threads
nils4cosee
force-pushed
the
issue-399-dangerous-use-of-forkjoinpool
branch
from
87f2031 to
3980752
Compare
michael-burwig
approved these changes
Jun 9, 2020
stevesap
added
community
|
Branch out of date, cannot update/push to your fork branch :( |
|
Closing in favour of #518. Thanks again for your contribution. |
stevesap
removed
the
in review
|
@michael-burwig We noticed that you cannot switch on "maintainers can commit" in a fork of an organisation, sorry about that. |
|
My apologies again for not having picked this PR after all. The issue in question became more and more pressing due to performance/high availability tests that were scheduled on that day. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #399:
While a scheduled-executor makes sense for timing the response to
fake-requests, real requests should better be handled in the web-thread
directly. We still use the DeferredResult to as response, but do not
run real requests in new threads.
Checklist
mvn installruns for the whole project and, if you touched any code in the respective service, submission and distribution service can be run withspring-boot:runDescription