Skip to content
This repository has been archived by the owner on May 16, 2023. It is now read-only.

fixed sonar issues #1996

Merged
merged 8 commits into from
Jan 30, 2023
Merged

fixed sonar issues #1996

merged 8 commits into from
Jan 30, 2023

Conversation

mfromme
Copy link
Contributor

@mfromme mfromme commented Jan 10, 2023

Checklist

  • Test your changes as thoroughly as possible before you commit them. Preferably, automate your test by unit/integration tests.
  • Make sure mvn -P integration-test clean verify runs for the whole project and, if you touched any code for a service in the services folder, ensure it can be run with spring-boot:run

Description

@mfromme mfromme requested review from a team, roesslerj and hilmarf January 10, 2023 19:17
@github-actions
Copy link

github-actions bot commented Jan 10, 2023

Unit Test Results

2 527 tests  +1 372   2 526 ✔️ +1 372   26m 19s ⏱️ + 6m 26s
   221 suites +     49          1 💤 ±       0 
   221 files   +     49          0 ±       0 

Results for commit 965056d. ± Comparison against base commit ae2f632.

♻️ This comment has been updated with latest results.

@hilmarf hilmarf enabled auto-merge (squash) January 14, 2023 16:53
@hilmarf hilmarf dismissed roesslerj’s stale review January 30, 2023 10:07

requested changes are done

@hilmarf hilmarf added this to the 3.1 milestone Jan 30, 2023
@hilmarf hilmarf disabled auto-merge January 30, 2023 10:34
@hilmarf hilmarf enabled auto-merge (squash) January 30, 2023 10:37
@sonarcloud
Copy link

sonarcloud bot commented Jan 30, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 8 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@hilmarf hilmarf merged commit 4aee6a2 into main Jan 30, 2023
@hilmarf hilmarf deleted the fixSonarIssues branch January 30, 2023 11:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants