Remove missing .yaml attribute validation test (#652)

corona-warn-app · Jul 6, 2020 · 3fee1fb · 3fee1fb
1 parent ac86a35
commit 3fee1fb
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 55 deletions.
diff --git a/...oronawarn/server/services/distribution/assembly/appconfig/validation/ValidationError.java b/...oronawarn/server/services/distribution/assembly/appconfig/validation/ValidationError.java
@@ -79,7 +79,6 @@ public enum ErrorType {
     VALUE_OUT_OF_BOUNDS,
     INVALID_URL,
     INVALID_PARTITIONING,
-    TOO_MANY_DECIMAL_PLACES,
-    MISSING_ENTRY
+    TOO_MANY_DECIMAL_PLACES
   }
 }
diff --git a/...rvices/distribution/assembly/appconfig/validation/ExposureConfigurationValidatorTest.java b/...rvices/distribution/assembly/appconfig/validation/ExposureConfigurationValidatorTest.java
@@ -22,7 +22,6 @@
 
 import static app.coronawarn.server.services.distribution.assembly.appconfig.validation.ExposureConfigurationValidator.CONFIG_PREFIX;
 import static app.coronawarn.server.services.distribution.assembly.appconfig.validation.RiskScoreClassificationValidatorTest.buildError;
-import static app.coronawarn.server.services.distribution.assembly.appconfig.validation.ValidationError.ErrorType.MISSING_ENTRY;
 import static app.coronawarn.server.services.distribution.assembly.appconfig.validation.ValidationError.ErrorType.TOO_MANY_DECIMAL_PLACES;
 import static app.coronawarn.server.services.distribution.assembly.appconfig.validation.ValidationError.ErrorType.VALUE_OUT_OF_BOUNDS;
 import static org.assertj.core.api.Assertions.assertThat;
@@ -69,8 +68,6 @@ private static Stream<Arguments> createOkTests() {
   private static Stream<Arguments> createFailedTests() {
     return Stream.of(
         ScoreTooHigh(),
-        // TODO cwa-server/#320 Validate that no attributes are missing in .yaml
-        // ScoreNegative(),
         WeightNegative(),
         WeightTooHigh()
     ).map(Arguments::of);
@@ -103,12 +100,6 @@ public static TestWithExpectedResult WeightTooHigh() {
         .with(buildError(CONFIG_PREFIX + "transmission", 101d, VALUE_OUT_OF_BOUNDS));
   }
 
-  public static TestWithExpectedResult ScoreNegative() {
-    return new TestWithExpectedResult("score_negative.yaml")
-        .with(buildError(CONFIG_PREFIX + "transmission.appDefined1", RiskLevel.UNRECOGNIZED, VALUE_OUT_OF_BOUNDS))
-        .with(buildError(CONFIG_PREFIX + "transmission.appDefined3", null, MISSING_ENTRY));
-  }
-
   public static TestWithExpectedResult ScoreTooHigh() {
     return new TestWithExpectedResult("score_too_high.yaml")
         .with(buildError(CONFIG_PREFIX + "transmission.appDefined1", RiskLevel.UNRECOGNIZED, VALUE_OUT_OF_BOUNDS))

diff --git a/services/distribution/src/test/resources/parameters/score_negative.yaml b/services/distribution/src/test/resources/parameters/score_negative.yaml