Skip to content
This repository has been archived by the owner on May 16, 2023. It is now read-only.

Revert Accessibility Statement in Footer #70

Merged
merged 1 commit into from
Jan 31, 2023

Conversation

larswmh
Copy link
Member

@larswmh larswmh commented Jan 31, 2023

This reverts commit 962411d.

In response to #68, we decided to handle the issue by reverting the commit that initally brought in the link to the accessibility statement. As @MikeMcC399 explained, accessibility measures that have been taken on the main website were never taken on this site.


Internal Tracking ID: EXPOSUREAPP-14671

This reverts commit 962411d.
@larswmh larswmh merged commit 695a8ce into main Jan 31, 2023
@larswmh larswmh deleted the update/footer-revert-accessibility-link branch January 31, 2023 11:25
@Ein-Tim
Copy link
Contributor

Ein-Tim commented Jan 31, 2023

@dsarkar @larswmh

In the past, it was the goal to keep both the footer of the main page https://coronawarn.app & the pages which are based on this repositories code, in sync. I assume this is not relevant anymore?

@dsarkar
Copy link
Member

dsarkar commented Jan 31, 2023

@Ein-Tim Sure, in principle, to keep them all in sync makes sense and also looks better. However, in the case of the accessibility statement, it could be misunderstood that it refers also to the landing pages. This statement is for https://coronawarn.app/. One could argue that it says so specifically at the top of the page, sure. Let's say, removing it from the footer, could prevent misunderstanding.

Anyway, still open to add it at a later point, particularly, if we need to deploy again. For now let's keep it how it is/was.

Thanks for your input.

@MikeMcC399
Copy link
Contributor

@Ein-Tim

The footer of corona-warn-app/cwa-event-landingpage would require the implementation of the accessibility updates to make it identical to the footer of corona-warn-app/cwa-website.

There is little justification to putting the work into making accessibility changes to this site including the effort of both development and testing:

  • The site is only displayed if a user does not yet have CWA installed, so in the meantime this is an edge case with millions of users already having the app installed.
  • The project is now entering the ramp-down phase where further enhancements are not expected.

You can compare the code of the two footers and you will see that the structures are quite different.


https://e.coronawarn.app/en/

image


https://www.coronawarn.app/en/

image


If for some unexpected reason this site is going to continue a lot longer, then accessibility enhancements should be made so that users who require this can correctly navigate to the download buttons. At the same time the footer could also be enhanced for accessibility.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Literal display of &shy in the footer of the page
4 participants