Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

Conversation

30mar
Copy link
Contributor

@30mar 30mar commented Mar 21, 2023

Description

stop risk calculation and downloading packages in EOL mode

Link to Jira

https://jira-ibs.wbs.net.sap/browse/EXPOSUREAPP-14958

@30mar 30mar added the bug Something isn't working label Mar 21, 2023
@30mar 30mar added this to the v3.2.0 milestone Mar 21, 2023
@30mar 30mar requested a review from a team March 21, 2023 11:59
Copy link
Contributor

@flxschmidt flxschmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! One minor remark.

@@ -86,6 +86,71 @@ class RiskProviderTests: CWATestCase {

}

func testGIVEN_RiskCalculation_WHEN_ENFRiskHighAndCheckinRiskLow_THEN_RiskConsumerReturnsRiskHigh_EOL() {
// GIVEN
UserDefaults.standard.setValue(true, forKey: CWAHibernationProvider.isHibernationInUnitTest)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please set it also to false at the end of the test.

@30mar 30mar merged commit ed075c6 into release/3.2.x Mar 21, 2023
@30mar 30mar deleted the fix/14958-Risk-still-active-and-executed-incl.-Deadman-Notification-although-App-in-EOL branch March 21, 2023 15:58
@naveeddotio naveeddotio changed the title stop risk calculation and package download in EOL Fix/14958 stop risk calculation and package download in EOL Mar 28, 2023
@naveeddotio naveeddotio changed the title Fix/14958 stop risk calculation and package download in EOL Fix/14958 Stop risk calculation and package download in EOL Mar 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants