This repository has been archived by the owner on Jun 20, 2023. It is now read-only.
Fix/14950 Update homescreen when app becomes active #5096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flxschmidt
suggested changes
Mar 16, 2023
| @@ -102,28 +102,6 @@ class HomeTableViewController: UITableViewController, NavigationBarOpacityDelega | |||
| ) | |||
| } | |||
| .store(in: &subscriptions) | |||
|
|
|||
| viewModel.cclService.shouldShowNoticeTile | |||
There was a problem hiding this comment.
With this deletion we would ignore the CCL config for App Closure Notice. I know it makes sense, because we show either the notice or the thank-you tile. But is it aligned with the Tech Spec?
src/xcode/ENA/ENA/Source/Scenes/Home/HomeTableViewController.swift
Outdated
Show resolved
Hide resolved
src/xcode/ENA/ENA/Source/Scenes/Home/HomeTableViewController.swift
Outdated
Show resolved
Hide resolved
| @@ -366,7 +365,7 @@ class HomeTableViewModel { | |||
| return 1 | |||
| } | |||
| #endif | |||
| if shouldShowAppClosureNotice, !isHibernationState { | |||
There was a problem hiding this comment.
As mentioned above, that's a static decision, without CCL config.
30mar
changed the base branch from
story/14427-ramp-down-cwa
to
release/ramp-down.x
…actualized-in-background-after-switching-to-hibernation-state
…wift Co-authored-by: Felix Schmidt <[email protected]>
…wift Co-authored-by: Felix Schmidt <[email protected]>
…fter-switching-to-hibernation-state' of github.com:corona-warn-app/cwa-app-ios into fix/14950-Home-screen-is-not-actualized-in-background-after-switching-to-hibernation-state
naveeddotio
changed the title
…actualized-in-background-after-switching-to-hibernation-state
30mar
deleted the
fix/14950-Home-screen-is-not-actualized-in-background-after-switching-to-hibernation-state
branch
naveeddotio
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
make sure home screen is updated by subscribing to notification didBecomeActive
Note we are now reloading the whole table view because we are refreshing almost all the sections not just one or 2 like the past.
Link to Jira
https://jira-ibs.wbs.net.sap/browse/EXPOSUREAPP-14950
##Video
https://user-images.githubusercontent.com/15270737/225344504-94bb80f8-bd97-49a6-acc8-63c1ff5f0472.MP4