Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

Adjust info screen to announce new Release-Features for 3.1 #5020

Conversation

30mar
Copy link
Contributor

@30mar 30mar commented Jan 26, 2023

Description

Adjust Info Screen to announce new Release-Features for 3.1

Link to Jira

https://jira-ibs.wbs.net.sap/browse/EXPOSUREAPP-14606

@30mar 30mar added the feature label Jan 26, 2023
@30mar 30mar added this to the v3.1.0 milestone Jan 26, 2023
@30mar 30mar requested review from a team January 26, 2023 08:23
Copy link
Contributor

@KathrinLuecke KathrinLuecke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UA approved

static let feature30WarningUnregisteredTestsDescription = NSLocalizedString("NewVersionFeature_30_warning_unregistered_tests_description", comment: "")
static let feature30TANHotlineRemovalTitle = NSLocalizedString("NewVersionFeature_30_tan_hotline_removal_title", comment: "")
static let feature30TANHotlineRemovalDescription = NSLocalizedString("NewVersionFeature_30_tan_hotline_removal_description", comment: "")
/* Version 3.1 */
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/* Version 3.1 */

"NewVersionFeature_30_tan_hotline_removal_title" = "TAN Hotline entfällt";

"NewVersionFeature_30_tan_hotline_removal_description" = "Die Möglichkeit, eine TAN über die TAN-Hotline zu erhalten, entfällt in einigen Wochen. Sie können nun ohne TAN andere Nutzer der Corona-Warn-App warnen.";
/* Version 3.1 */
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line can be removed.

Suggested change
/* Version 3.1 */

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is just to keep the convention, this way for 3.2 we know where to add the lines, what do you think?

@naveeddotio naveeddotio changed the title Adjust Info Screen to announce new Release-Features for 3.1 Adjust info Screen to announce new Release-Features for 3.1 Jan 26, 2023
@naveeddotio naveeddotio changed the title Adjust info Screen to announce new Release-Features for 3.1 Adjust info screen to announce new Release-Features for 3.1 Jan 26, 2023
Copy link
Contributor

@naveeddotio naveeddotio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove extra lines

Copy link
Contributor

@puneetmahali1 puneetmahali1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Some minor comments as Naveed mentioned.

@naveeddotio naveeddotio merged commit 1ed45f7 into release/3.1.x Jan 27, 2023
@naveeddotio naveeddotio deleted the feature/14606-Adjust-Info-Screen-to-announce-new-Release-Features-for-3.1 branch January 27, 2023 14:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants