This repository has been archived by the owner on Jun 20, 2023. It is now read-only.
Fix/11222 remove badge count from redeemed tests #4994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naveeddotio
changed the title
flxschmidt
reviewed
Jan 13, 2023
src/xcode/ENA/ENA/Source/Scenes/ExposureSubmission/ExposureSubmissionCoordinator.swift
Show resolved
Hide resolved
src/xcode/ENA/ENA/Source/Scenes/ExposureSubmission/ExposureSubmissionCoordinator.swift
Show resolved
Hide resolved
flxschmidt
approved these changes
Jan 13, 2023
naveeddotio
reviewed
Jan 13, 2023
| @@ -1794,6 +1797,8 @@ class ExposureSubmissionCoordinator: NSObject, RequiresAppDependencies { | |||
| message: error.localizedDescription, | |||
| completion: { [weak self] in | |||
| self?.dismiss() | |||
| // reset the home badge count | |||
| self?.badgeWrapper.resetAll() | |||
There was a problem hiding this comment.
You are resetting the total count, that means, if there was a count before that was unrelated to this condition here, will also be reseted.
naveeddotio
suggested changes
Jan 13, 2023
naveeddotio
approved these changes
Feb 16, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After scan the redeemed tests it was showing the badge count status.
Link to Jira
https://jira-ibs.wbs.net.sap/browse/EXPOSUREAPP-11222
Screenshots
EXPOSUREAPP-11222.MP4