This repository has been archived by the owner on Jun 20, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 284
Fix/10498 Show New Functions Screen footernote only with delta onboarding #4854
Merged
puneetmahali1
merged 12 commits into
release/2.29.x
from
fix/10498-remove-new-functions-screen-footernote
Nov 2, 2022
Merged
Fix/10498 Show New Functions Screen footernote only with delta onboarding #4854
puneetmahali1
merged 12 commits into
release/2.29.x
from
fix/10498-remove-new-functions-screen-footernote
Nov 2, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naveeddotio
changed the title
fix/10498 Show New Functions Screen footernote only with delta onboarding
Fix/10498 Show New Functions Screen footernote only with delta onboarding
Oct 25, 2022
naveeddotio
reviewed
Oct 26, 2022
src/xcode/ENA/ENA/Source/Scenes/AppInformation/AppInformationViewController.swift
Outdated
Show resolved
Hide resolved
naveeddotio
suggested changes
Nov 2, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix this as discussed
30mar
approved these changes
Nov 2, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No comments except what naveed said
Thanks Naveed, Done! |
naveeddotio
approved these changes
Nov 2, 2022
puneetmahali1
deleted the
fix/10498-remove-new-functions-screen-footernote
branch
November 2, 2022 15:03
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The footernote cell on New Functions Screen was displaying at the time of delta onboarding and after that navigate from App Information. Now, it should display only with the delta onboarding.
Link to Jira
https://jira-ibs.wbs.net.sap/browse/EXPOSUREAPP-10498
Screenshots
both.case.mov