Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unit-aware arithmetics #36

Merged
merged 1 commit into from
Aug 31, 2023
Merged

Fix unit-aware arithmetics #36

merged 1 commit into from
Aug 31, 2023

Conversation

coroa
Copy link
Owner

@coroa coroa commented Jul 26, 2023

Fixes #35

  • Add tests
  • Add documentation

@codecov-commenter
Copy link

codecov-commenter commented Jul 26, 2023

Codecov Report

Patch coverage: 55.55% and project coverage change: -0.66% ⚠️

Comparison is base (8ee04da) 77.53% compared to head (3744529) 76.87%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #36      +/-   ##
==========================================
- Coverage   77.53%   76.87%   -0.66%     
==========================================
  Files           9        9              
  Lines         681      692      +11     
  Branches      176      183       +7     
==========================================
+ Hits          528      532       +4     
- Misses        125      132       +7     
  Partials       28       28              
Files Changed Coverage Δ
src/pandas_indexing/arithmetics.py 42.30% <42.85%> (-4.21%) ⬇️
src/pandas_indexing/accessors.py 90.00% <100.00%> (+0.20%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coroa coroa force-pushed the fix-unit-arithmetics branch from 69adde2 to 3744529 Compare August 30, 2023 21:26
@coroa coroa merged commit 6e21d0b into main Aug 31, 2023
@coroa coroa deleted the fix-unit-arithmetics branch August 31, 2023 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing documentation and tests for the revised arithmetics
2 participants